Make email address usernames match label constraints#72
Closed
miguelpires wants to merge 1 commit intocanonical:mainfrom
Closed
Make email address usernames match label constraints#72miguelpires wants to merge 1 commit intocanonical:mainfrom
miguelpires wants to merge 1 commit intocanonical:mainfrom
Conversation
Google cloud was rejecting the "owner" resources label when run by users with email addresses as usernames (corp setup). This does a quick, best-effort check for an email address-like username and tries to extract the personal part of it and convert it to a format Google accepts. We could just use base64url which would be accepted but then the label wouldn't be as friendly for humans to read. Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
miguelpires
had a problem deploying
to
OS_AMD64_PS7
GitHub Actions
Failure
miguelpires
had a problem deploying
to
OS_AMD64_PS7
GitHub Actions
Failure
miguelpires
had a problem deploying
to
OS_ARM64_PS7
GitHub Actions
Failure
miguelpires
had a problem deploying
to
OS_AMD64_PS7
GitHub Actions
Failure
miguelpires
had a problem deploying
to
OS_ARM64_PS7
GitHub Actions
Failure
miguelpires
had a problem deploying
to
OS_AMD64_PS7
GitHub Actions
Failure
Contributor
Author
|
Superseeded by #73 (PR from a branch instead of a fork) |
miguelpires
temporarily deployed
to
OS_AMD64_PS7
GitHub Actions
Inactive
miguelpires
temporarily deployed
to
OS_ARM64_PS7
GitHub Actions
Inactive
miguelpires
had a problem deploying
to
OS_AMD64_PS7
GitHub Actions
Failure
miguelpires
temporarily deployed
to
OS_AMD64_PS7
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google cloud was rejecting the "owner" resources label when run by users with email addresses as usernames (corp setup). This does a quick, best-effort check for an email address-like username and tries to extract the personal part of it and convert it to a format Google accepts. We could just use base64url which would be accepted but then the label wouldn't be as friendly for humans to read.