fix: parse string and file credentials in uniform way#280
Open
fix: parse string and file credentials in uniform way#280
Conversation
Collaborator
Author
|
Execution of tests fails in this PR because tests run with a pinned commit of spread. The pinned commit will be updated to after this PR lands, allowing future tests to execute successfully. Local test execution results using this PR and authorized user credentials: |
The Google backend key parsing implementation used JWTConfigFromJSON() when the key is specified as a JSON string, and this only works with service account credentials. In contrast, when setting the key to the path of a file containing the JSON credentials we use the environment GOOGLE_APPLICATION_CREDENTIALS, which also accepts authorized user credentials. Change the JSON string key parsing to use CredentialsFromJSON() to match the functionality of reading the JSON from a file, allowing the use of authorized user credentials with string keys. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
work/accept-authorized-user-credentials
branch
from
b47af27 to
e75651c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Google backend credential parsing so JSON credentials provided
inline as a string are handled the same way as credentials read from a file
(via GOOGLE_APPLICATION_CREDENTIALS), enabling authorized user
credentials for string keys as well.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com