pro: replace deprecated cloud-init key ubuntu_advantage#2069
Draft
ogayot wants to merge 1 commit intocanonical:mainfrom
Draft
pro: replace deprecated cloud-init key ubuntu_advantage#2069ogayot wants to merge 1 commit intocanonical:mainfrom
ogayot wants to merge 1 commit intocanonical:mainfrom
Conversation
On cloud-init versions >= 24.1, having the ubuntu_advantage key leads to the following deprecation notice: > cc_ubuntu_pro.py[WARNING]: Deprecated configuraiton key(s) provided: > ubuntu_advantage. Expected "ubuntu_pro": will attempt to continue. Let's use ubuntu_pro instead ; which should be available on 20.04.5, 22.04.5 and all the 24.04+ ISOs. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
deprecated-ubuntu-advantage
branch
from
d37de44 to
2f225ab
Compare
blackboxsw
reviewed
Sep 3, 2024
Contributor
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
The ubuntu_pro support is available in cloud-init and ubuntu pro in Focal and later as of cloud-init version 24.1. Looks good to me on the initial approach.
| python3 scripts/check-yaml-fields.py <(python3 scripts/check-yaml-fields.py $tmpdir/etc/cloud/cloud.cfg.d/99-installer.cfg datasource.None.userdata_raw) \ | ||
| locale='"en_GB.UTF-8"' \ | ||
| timezone='"Pacific/Guam"' \ | ||
| ubuntu_advantage.token='"C1NWcZTHLteJXGVMM6YhvHDpGrhyy7"' \ |
Contributor
There was a problem hiding this comment.
Encoding a token publicly in a repo gave me pause, but Just confirmed that this token is, in fact, invalid/not real and cannot be used to attach.
| # documentation. | ||
| return { | ||
| "ubuntu_advantage": { | ||
| "ubuntu_pro": { |
Contributor
There was a problem hiding this comment.
@ogayot looks good to me. Moving to ubuntu_pro is supported on 20.04 and later for cloud-init version 24.1 which published to the archive in June.
There are two uploads under review that will make this valid as well for 16.04 and 18.04 if that becomes something you need to support, but that hasn't landed yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On cloud-init versions >= 24.1, having the ubuntu_advantage key leads to the following deprecation notice:
Let's use ubuntu_pro instead ; which should be available on 20.04.5, 22.04.5 and all the 24.04+ ISOs.
Marking as a draft before I figure out what we want to do for older ISOs + refresh.