Refactor command runners to reduce coupling. #2308
Draft
+384
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today LoggedCommandRunner and DryRunCommandRunner are very coupled with systemd-run. By introducing command wrappers, we reduce the coupling. Signed-off-by: Olivier Gayot <[email protected]>
Signed-off-by: Olivier Gayot <[email protected]>
To reduce coupling even more, introduce the CommandRunner base class. CommandRunner does not have support for command wrappers for now, but it at least handles the backend. Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
runners-refactor
branch
from
ef235a2 to
4a8d138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much of the logic for runners is implemented in
LoggedCommandRunner.We now introduce command-wrappers. Command wrappers wrap (e.g., prefix) commands with something, such as systemd-run, sleep-and-execute, ...
Next, we could have a command wrapper that adds a timeout for instance.
We also introduce the concept of backend - with astart_command being the only one supported at the moment.
This reduces the responsibilities of
LoggedCommandRunnerand allows to combine different command wrappers with more ease.