-
Notifications
You must be signed in to change notification settings - Fork 7
ISD-2819 restart synapse and MAS if MAS config has changed #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISD-2819 restart synapse and MAS if MAS config has changed #779
Conversation
Test results for commit 61cae0dTest coverage for 61cae0d
Static code analysis report
|
config = container.pull(MAS_CONFIGURATION_PATH).read() | ||
return yaml.safe_load(config) | ||
except ops.pebble.PathError as exc: | ||
# If the MAS config has not been created, we return an empty dict to trigger a replan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When could this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 most likely cases are:
When the charm first starts, or when the config is manually deleted for whatever reason
Check for drifts using the existing method for synapse config and restart both Synapse and MAS if the config has changed.
Checklist
urgent
,trivial
,senior-review-required
)