[Fix] Searching test results with execution metadata never returns #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searching test results with execution metadata never returns. It takes too long.
My fix here is a refactor. I believe the previous solution was building a VERY large table in memory. This implementation is more in line with standard practices and performs quite a bit better with a large number of test executions and test results.
Resolved issues
Cannot use metadata on test results page.
Documentation
N/A
Web service API changes
N/A
Tests
Purely a refactor, all unit tests for attachment rules and test results search that depend on this logic still pass.
Tested locally using a restored dump of the production test observer database. Verified without the change that the page will not load, and with the change it does.