Skip to content

Conversation

@swetha1654
Copy link

@swetha1654 swetha1654 commented Oct 14, 2025

Applicable spec:

Overview

Fixes #30

Rationale

Root cause: _wait_for(partial(systemd.service_running, TMATE_SERVICE_NAME), timeout=60 * 10) returns True for a short period of time after the service restarts before returning False, leading to the code falsely assuming that the service is running even though it failed.
Added another check to see if the docker container is running, this check is more robust.

Juju Events Changes

Module Changes

Library Changes

Checklist

@swetha1654 swetha1654 added the bug Something isn't working label Oct 16, 2025
@swetha1654 swetha1654 marked this pull request as ready for review October 16, 2025 04:42
@swetha1654 swetha1654 requested a review from a team as a code owner October 16, 2025 04:42
@swetha1654 swetha1654 changed the title Fix charm status Fix: Add container running check after service restarts Oct 16, 2025
@swetha1654 swetha1654 requested review from cbartz, yanksyoon and yhaliaw and removed request for florentianayuwono and srbouffard October 16, 2025 04:45
Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Swetha! Looks good, but I have comments related to the tests.

@swetha1654 swetha1654 requested review from cbartz and yhaliaw October 23, 2025 05:25
@swetha1654 swetha1654 enabled auto-merge (squash) October 24, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment should go in error or blocked state when docker is not able to start

3 participants