Cleanup rocks #92
Merged
Cleanup rocks #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@claudiubelu Have you used any lint tool, if so can we add it to tox.ini |
I haven't. |
hemanthnakkina
previously requested changes
Jun 23, 2025
claudiubelu
force-pushed
the
rocks-cleanup
branch
from
7f715b6 to
cc29599
Compare
Fixes some of the lints seen in various rocks' rockcraft.yaml files. Additionally, the masakari rocks services are not running with the created masakari user, and masakari-api doesn't clear the /etc/apache2/ports.conf file. Signed-off-by: Claudiu Belu <[email protected]>
claudiubelu
force-pushed
the
rocks-cleanup
branch
from
cc29599 to
4467073
Compare
gboutry
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the lints seen in various rocks'
rockcraft.yamlfiles. Additionally, the masakari rocks services are not running with the createdmasakariuser, andmasakari-apidoesn't clear the/etc/apache2/ports.conffile.