-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate external sru docs #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, generally looks good! I've spotted some nits, and some other things that are blocking the automated checks. In addition to the inline comments:
- You'll want to add "SRUs" and "StableReleaseUpdates" to the spelling ignore list
- Deleting the
stable-release-udpates.rst
file has broken a link indebian-merges-and-syncs.rst
at line 42 - There are two links that say "broken" - they're not really broken, but they are redirecting so we probably want to update them:
Co-authored-by: Sally <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dviererbe! Some nitpicks and a necessary fix (updating the link to the removed SRU file).
#. Get the package with the SRU patch into the upload queue. | ||
#. The SRU team will then review from the unapproved queue. When the upload is | ||
ready, the SRU team accepts the upload into the proposed pocket. | ||
#. Once the builds are ready, autopkgtest are triggered. Test the binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resource will be the article in this guide (once it's added ;)): https://canonical-ubuntu-packaging-guide.readthedocs-hosted.com/en/latest/how-to/run-tests/. In the meantime, the info is all over the place:
The removal of the file `docs/explanation/stable-release-updates.rst` caused a broken link. This commit fixes the link.
Co-authored-by: Robert Krátký <[email protected]>
Add glossary entries for teh terms: - autopkgtest - autopkgtest Cloud - Debian Enhancement Proposal - DEP - DEP 8
@rkratky I incorporated your and Sallys feedback and fixed false negatives in the spellcheck. There are two links that say "broken", but they're not really broken. Can you re-review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dviererbe.
This PR integrates and refers to the new SRU documentation: https://canonical-sru-docs.readthedocs-hosted.com/en/latest/
The dedicated SRU doc (introduced with #69) is moved to
explanation/development-process
and reduced to the most important information, just to give a brief overview of the process.