Replace ASCII art with mermaid diagrams in WireGuard section#635
Open
s-makin wants to merge 5 commits intocanonical:mainfrom
Open
Replace ASCII art with mermaid diagrams in WireGuard section#635s-makin wants to merge 5 commits intocanonical:mainfrom
s-makin wants to merge 5 commits intocanonical:mainfrom
Conversation
Contributor
|
Thank you @s-makin :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately the original set of PR(s) that updated the ASCII art in the WireGuard section became quite complicated to merge due to a large number of conflicts with subsequent changes.
I have manually applied all of the changes proposed by @MariaBego56 onto a fresh/clean branch to avoid all of these conflicts, and it should be now good to merge.
The diagrams should now all be rendering correctly, and I have also fixed the issue that prevented RTD from building the 391 PR.
Thank you again, @MariaBego56 for creating these diagrams, and for all your patience as we worked through all the different build problems! Mermaid can be tricky, but we got there in the end.
Related Issue
Checklist