-
Notifications
You must be signed in to change notification settings - Fork 19
process: Coordinating Weight Changes Across Networks #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hythloda
wants to merge
8
commits into
main
Choose a base branch
from
weight-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6cc1d38
draft of weight changes
hythloda 67bd47c
Merge branch 'main' into weight-changes
hythloda 4c23018
Merge branch 'main' into weight-changes
hythloda 383d336
Merge branch 'main' into weight-changes
hythloda 44bdb12
Merge branch 'main' into weight-changes
hythloda ad68a52
changes from review
hythloda e24f481
Merge branch 'main' into weight-changes
hythloda 041596d
weight changes: mention automated check
stas-sbi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| ## Coordinating Weight Changes Across Networks | ||
|
|
||
| ### Purpose | ||
|
|
||
| This process ensures that on-chain Super Validator weight votes remain in sync with our public GitHub configuration (`approved-sv-id-values.yaml`), and that any SV re-onboarding uses the correct, network-approved weights. | ||
|
|
||
| ### Process | ||
|
|
||
| #### 1. Initiate on-chain vote | ||
| - Propose weight changes via on-chain governance under “Option 3a” (single synchronized vote across all networks with a common effective date). | ||
|
hythloda marked this conversation as resolved.
Outdated
hythloda marked this conversation as resolved.
Outdated
|
||
|
|
||
| #### 2. Update the GitHub configuration | ||
| - After the vote passes, update `approved-sv-id-values.yaml` in the [SV config repo on GitHub](https://sync.global). | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
| - Ensure the new weight values and effective date match the on-chain vote exactly. | ||
|
|
||
|
hythloda marked this conversation as resolved.
Outdated
|
||
| #### 3. Submit a Pull Request | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
| - The node operator who proposed the weight change creates a PR against `approved-sv-id-values.yaml`. | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
| - In the PR description, reference the on-chain vote transaction ID and effective date. | ||
| - Tag the maintainers (`@gsf-maintainers`) as reviewers. | ||
|
hythloda marked this conversation as resolved.
Outdated
hythloda marked this conversation as resolved.
Outdated
|
||
|
|
||
| #### 4. Review & Merge | ||
| - Maintainers review the PR for accuracy and consistency. | ||
| - Once approved, merge the PR so the public file reflects the live network state. | ||
|
hythloda marked this conversation as resolved.
Outdated
hythloda marked this conversation as resolved.
Outdated
|
||
|
|
||
| #### 5. Publication & Confirmation | ||
| - The merged file is automatically published at https://sync.global. | ||
|
hythloda marked this conversation as resolved.
Outdated
hythloda marked this conversation as resolved.
Outdated
|
||
| - SV operators may verify weights by inspecting this public file. | ||
|
|
||
| #### 6. Re-onboarding behavior | ||
| - If an SV is off-boarded and then re-onboards, they will receive the weight defined in the merged `approved-sv-id-values.yaml`. | ||
|
|
||
| #### 7. Enforcement & Escalation | ||
| - If the PR is not opened within 24 hours of vote finalization, the proposing node may be flagged for non-compliance. | ||
| - Repeated failures to submit or merge the PR may trigger an off-boarding vote or reconsideration of “Option 2” (automatic enforcement). | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
|
|
||
| --- | ||
|
|
||
| ### Prior discussion and votes for reference | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
|
|
||
| **YES: Separate PRs** | ||
| - *pros:* immediate config/runtime consistency; avoids drift | ||
| - *cons:* more PRs to manage; splits workflow into smaller steps | ||
|
|
||
| **NOT Ignoring** (default) | ||
| - *pros:* simplest—no extra steps | ||
| - *cons:* renders the consistency check pointless; risk of unnoticed drift | ||
|
|
||
| **Single PR + Reminders** | ||
| - *pros:* fewer PRs; single source of truth for all envs | ||
| - *cons:* requires active monitoring; notification fatigue leads to ignored reminders | ||
|
|
||
| **Option 3a: Single PR with Common Effective Date** | ||
| - Keep one PR per vote round when all networks share the same activation date | ||
|
hythloda marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.