Skip to content

process: add docs for adding readonly request access#130

Open
v9n wants to merge 5 commits intocanton-foundation:mainfrom
fivenorth-io:add-docs-for-adding-readonly-ip
Open

process: add docs for adding readonly request access#130
v9n wants to merge 5 commits intocanton-foundation:mainfrom
fivenorth-io:add-docs-for-adding-readonly-ip

Conversation

@v9n
Copy link
Copy Markdown
Contributor

@v9n v9n commented Jul 7, 2025

Define an initial process to submit read-only ip access

@v9n v9n requested a review from a team as a code owner July 7, 2025 18:24
@v9n v9n force-pushed the add-docs-for-adding-readonly-ip branch from 762ffe6 to f74b81f Compare July 7, 2025 18:38
Comment thread processes/new-whitelisted-ip.md Outdated
Comment thread processes/new-whitelisted-ip.md Outdated
@isegall-da
Copy link
Copy Markdown
Contributor

Thanks @v9n
This seems to be duplicating quite a lot of stuff from the process above it, WDYT of just adding the missing points to the existing text instead?

@v9n
Copy link
Copy Markdown
Contributor Author

v9n commented Jul 7, 2025

Thanks @v9n This seems to be duplicating quite a lot of stuff from the process above it, WDYT of just adding the missing points to the existing text instead?

They looks similar on the steps today, but the context is quite different IMHO.

  • One is the first time someone setup validator. They are new and just want to get a validator up. They won't deal with anything else yet.

  • Other is when they already know some stuff around and now adding the read-only. By this time someone does the read only ip, they have more experience as well and we can keep the docs short and simple and less hand holding but more on policy.

I think let keep it separate, so we don't confused a newly user that is spinning up a validator. So we can keep that part clear, conscice and to the point. Adding less noise to that part is better.

v9n and others added 2 commits July 7, 2025 13:14
Co-authored-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Vinh <vinh@mailwip.com>
Co-authored-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Vinh <vinh@mailwip.com>
@stas-sbi stas-sbi changed the title add docs for adding readonly request access process: add docs for adding readonly request access Aug 21, 2025
@hythloda
Copy link
Copy Markdown
Contributor

@v9n Can you make the changes directly?

@v9n
Copy link
Copy Markdown
Contributor Author

v9n commented Sep 16, 2025

Hi @hythloda What change do I need to make to get this PR merge? I think Ital want some changes but I provided my though. let me ask Ital again.

Hi @isegall-da Do you think this is good? or you still want to merge the section and insert the part where they are different?

@hythloda hythloda requested a review from isegall-da September 16, 2025 13:53

Currently, only individual IPs are allowed, so you will need to explicitly write out multiple `/32` entries if you have a range. There isn't an official limit on how many IPs are allowed, but keep it fewer than three.

Unlike validator IPs, read-only access IP addresses can be reused across all network environments (**Dev**, **Test**, and **Main**).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Unlike validator IPs, read-only access IP addresses can be reused across all network environments (**Dev**, **Test**, and **Main**).

Outdated, that's allowed for validator IPs now too

Comment on lines +51 to +57
"<org-name> / <operator-name-or-sponsor-name>" : [
  "ip1/32",
  "ip2/32"
]
```

When the organization runs the node themselves, list the sponsor in the second part after the dash (/).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<org-name> / <operator-name-or-sponsor-name>" : [
  "ip1/32",
  "ip2/32"
]
```
When the organization runs the node themselves, list the sponsor in the second part after the dash (/).
"<org-name> / <sponsor-name>" : [
  "ip1/32",
  "ip2/32"
]

@isegall-da
Copy link
Copy Markdown
Contributor

@v9n If you're fine with my proposed changes, can you just accept and we'll merge? I think it's good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants