feat: add search column with @Common.Text annotation#1189
Conversation
etimr
requested review from
BobdenOs,
David-Kunz,
danjoa,
johannes-vogel,
patricebender,
sjvans and
stewsk
as code owners
| if (element?.['@Common.Text']?.['='] && element?.isAssociation) { | ||
| deepSearchCandidates.push({ ref: element['@Common.Text']['='].split('.') }) | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
We should move that out to a model pre-processor, that runs once on server start instead of polluting our db layers with such knowledge of OData / Fiori concepts , and doing that again and again per query at runtime
| @@ -1,5 +1,5 @@ | |||
| ID;title;descr;author_ID;stock;price;currency_code;genre_ID | |||
| 201;Wuthering Heights;"Wuthering Heights, Emily Brontë's only novel, was published in 1847 under the pseudonym ""Ellis Bell"". It was written between October 1845 and June 1846. Wuthering Heights and Anne Brontë's Agnes Grey were accepted by publisher Thomas Newby before the success of their sister Charlotte's novel Jane Eyre. After Emily's death, Charlotte edited the manuscript of Wuthering Heights and arranged for the edited version to be published as a posthumous second edition in 1850.";101;12;11.11;GBP;11 | |||
| 201;Wuthering Heights;"Wuthering Heights was published in 1847 under the pseudonym ""Ellis Bell"". It was written between October 1845 and June 1846. Wuthering Heights and Anne Brontë's Agnes Grey were accepted by publisher Thomas Newby before the success of their sister Charlotte's novel Jane Eyre.";101;12;11.11;GBP;11 | |||
There was a problem hiding this comment.
Why do we need to change these texts?
There was a problem hiding this comment.
I deleted the word "Emily" from the description, because I couldn't find any data for a test, where the result of the search would be different enough for search columns Books.title, Books.descr and for Books.title, Books.descr, Author.name(placeOfBirth/placeOfDeath).
|
❗️Until cds9 is released, we need to ensure code integrity by local testing. Please follow these steps to run your changes against all tests in our pipeline:
Once the matrix tests are green, confirm it here. |
3 participants
@CommonText : (author.name)is also tested