-
Notifications
You must be signed in to change notification settings - Fork 19
Add SPM support #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPM support #55
Conversation
|
Hmm, I am having trouble getting the CI to work. I'm not sure what to do for SPM testing, other projects like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area remove the test project. |
|
@all-contributors please add @aeharding for code. Let me take a quick look. |
|
I've put up a pull request to add @aeharding! 🎉 |
|
Build is passing! Had to migrate over the new |
|
@aeharding How did you verify this still works through CocoaPods? I"m having trouble verifying that. Did you test it with the example project? |
|
Hey @johnborges I tested with my project, Voyager, but I also just checked out the example project and it is working for me. Where are you having issues?
|
|
@aeharding I wanted to wait until Capacitor 7 was released to see what the official package manager direction would be for plugins long term before providing my comments on this. Your solution is the correct way to go, however merging it directly without bumping to a new major version won't work. v5 of this plugin need to remain using CocoaPods. The new version (v6) will exclusively support SPM. I took the changes you made here and incorporated them directly here #58 . I also included a couple additional things like updating the example project. |
|
Okay - however this PR should work fine with cocoapods and spm. I've been using this branch with cocoapods on my project. Do you have an error message or screenshot maybe I can help with? |

Hi there!
This PR adds SPM support for this plugin. It works well in my testing, including for Cocoapods (so it's backward compatible!)
Please let me know if you have any questions!