Skip to content

Conversation

@aeharding
Copy link
Contributor

Hi there!

This PR adds SPM support for this plugin. It works well in my testing, including for Cocoapods (so it's backward compatible!)

Please let me know if you have any questions!

@aeharding
Copy link
Contributor Author

Hmm, I am having trouble getting the CI to work. I'm not sure what to do for SPM testing, other projects like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area remove the test project.

@johnborges
Copy link
Collaborator

@all-contributors please add @aeharding for code.

Let me take a quick look.

@allcontributors
Copy link
Contributor

@johnborges

I've put up a pull request to add @aeharding! 🎉

@aeharding
Copy link
Contributor Author

Build is passing! Had to migrate over the new verify:ios script (and move some folders around)

@johnborges
Copy link
Collaborator

johnborges commented Dec 31, 2024

@aeharding How did you verify this still works through CocoaPods? I"m having trouble verifying that. Did you test it with the example project?

@johnborges johnborges added the enhancement New feature or request label Dec 31, 2024
@aeharding
Copy link
Contributor Author

Hey @johnborges I tested with my project, Voyager, but I also just checked out the example project and it is working for me. Where are you having issues?

Screenshot 2025-01-01 at 10 47 57 PM

@johnborges
Copy link
Collaborator

@aeharding I wanted to wait until Capacitor 7 was released to see what the official package manager direction would be for plugins long term before providing my comments on this.

Your solution is the correct way to go, however merging it directly without bumping to a new major version won't work. v5 of this plugin need to remain using CocoaPods. The new version (v6) will exclusively support SPM.

I took the changes you made here and incorporated them directly here #58 . I also included a couple additional things like updating the example project.

@johnborges johnborges closed this Jan 23, 2025
@aeharding
Copy link
Contributor Author

Okay - however this PR should work fine with cocoapods and spm. I've been using this branch with cocoapods on my project. Do you have an error message or screenshot maybe I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants