deprecate suppressNotification parameter in icon methods #72
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates the suppressNotification parameter in the icon change and reset methods. The parameter is being deprecated because it no longer works reliably on iOS 17+ and risks App Store rejection. The deprecation is marked for version 6.1.0.
- The
suppressNotificationparameter is marked as optional and deprecated in TypeScript definitions - Package version is bumped from 6.0.0 to 6.1.0
- iOS Swift implementation attempts to ignore the deprecated parameter
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/definitions.ts | Marks suppressNotification as optional and deprecated in both IconOptions and ResetOptions interfaces with appropriate JSDoc annotations |
| package.json | Bumps version from 6.0.0 to 6.1.0 to reflect the deprecation |
| ios/Sources/AppIconPlugin/AppIconPlugin.swift | Updates reset() and change() methods to ignore the deprecated parameter, but has a signature mismatch bug in the setIcon() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| setIcon(iconName: iconName, call) | ||
| } | ||
|
|
||
| func setIcon(iconName: String?, suppressNotification: Bool, _ call: CAPPluginCall) { |
There was a problem hiding this comment.
The setIcon method signature still includes the suppressNotification parameter, but the calls from reset() and change() no longer pass this argument. The method signature should be updated to remove the suppressNotification parameter, and the logic inside should be simplified to always use the public API (the else branch behavior).
No description provided.