Skip to content

feat: improve iOS detected devices view #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

talaviram
Copy link

This avoid overlapping / improved iOS device view.

Before this PR:

IMG_4735

After:

IMG_4736

@peitschie peitschie self-requested a review June 2, 2025 06:31
@peitschie
Copy link
Collaborator

peitschie commented Jun 2, 2025

Thanks for taking the time to raise this!

Interesting bug you've encountered here! I wish there was an easier way to workaround this...

The new interface you've added here looks ok, but it has a lot of visual and behaviour differences compared to the version it replaces.

Main things that stick out to me are:

  • The colours, fonts, layout and button shape are all very different from the original dialog
  • This dialog has a fixed height that takes up the majority of the screen, making it far less attractive if there are only one or two devices in the scan that are applicable

Would you have the time to try and align it a little more closely with the UIAlertController it replaces?

prior to this, it used Alert view that could easily be cluttered when
scanning without filters in a modern enviornment with > 10 devices.

this now uses UIPopoverPresentationController and UITableView to allow
scrollable list.
@talaviram
Copy link
Author

Ok, I've tried to make it feel more like a dialog for devices.
(mind that as you see also in the current alert the Scanning... is very small).

Anyway, more blurry like iOS and on iOS 15+ I can easily make the view take less space.
For iPad and macOS that was never an issue as it shows as a modal in the center.

Hope this is closer to what you had in mind.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants