Clarification of files location #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also could be great to add somewhere, should be added to the project with XCode |
|
and under Android |
schemenauero
suggested changes
Nov 19, 2024
| @@ -15,7 +15,7 @@ public class Constant { | |||
| public static let Loop = "loop" | |||
|
|
|||
| public static let ErrorAssetId = "Asset Id is missing" | |||
| public static let ErrorAssetPath = "Asset Path is missing" | |||
| public static let ErrorAssetPath = "Asset Path is missing or audio file can't be find" | |||
There was a problem hiding this comment.
Suggested change
| public static let ErrorAssetPath = "Asset Path is missing or audio file can't be find" | |
| public static let ErrorAssetPath = "Asset Path is missing or audio file can't be found" |
| @@ -5,7 +5,7 @@ public class Constant { | |||
| public static final String ERROR_AUDIO_ID_MISSING = "Audio Id is missing"; | |||
| public static final String ERROR_AUDIO_ASSET_MISSING = "Audio Asset is missing"; | |||
| public static final String ERROR_AUDIO_EXISTS = "Audio Asset already exists"; | |||
| public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing"; | |||
| public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be find"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be find"; | |
| public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be found"; |
| @@ -62,7 +62,7 @@ Sync native files | |||
| npx cap sync | |||
| ``` | |||
|
|
|||
| On iOS, Android and Web, no further steps are needed. | |||
| On iOS, Android and Web, no further steps are needed by stricly following the files location then just use the filename as *assetPath*. | |||
There was a problem hiding this comment.
This is better but the whole line is untrue if you need to open the project in xcode to get it working
|
Correct me if I am wrong but according to https://github.com/bazuka5801/native-audio-example/blob/master/src-capacitor/android/app/src/main/assets/fire.mp3 android directory is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, just added some clarification.