feat(barcode-scanning): pause and resume scan feature, cap 7 #300

bakai-dev-team · 2025-09-07T11:20:29Z

Pull request checklist

Please check if your PR fulfills the following requirements:

The changes have been tested successfully.
A changeset has been created (npm run changeset).
I have read and followed the pull request guidelines.

matthiasschwarz · 2025-09-07T20:00:52Z

Is this pull request related to #298?
If this is the case, this implementation would, at least for Android and the web, only pause and resume the barcode scan, but not freeze the camera preview.

bakai-dev-team · 2025-09-09T06:49:44Z

Is this pull request related to #298? If this is the case, this implementation would, at least for Android and the web, only pause and resume the barcode scan, but not freeze the camera preview.

Partially it resolves #298 too. We didn't test web version.

On Android

if pauseScan called it will skip all scanned results (will not resolve call) until resumeScan called

public void analyze(@NonNull ImageProxy imageProxy) {
        if (isPaused) {
            imageProxy.close();
            return;
        }
        ....
}

On iOS

It fill stop capture session (freeze) until resumeScan called

DispatchQueue.main.async {
          if let session = self.cameraView?.getCaptureSession() {
              if session.isRunning {
                  session.stopRunning()
              }
          }
}

robingenz · 2025-09-09T07:04:46Z

@bakai-dev-team It should freeze the camera view. Otherwise, this feature is useless since you can do the same in the webview (just remove the listener).

bakai-dev-team · 2025-10-06T09:56:05Z

@bakai-dev-team It should freeze the camera view. Otherwise, this feature is useless since you can do the same in the webview (just remove the listener).

On IOS it's already behaves as you mentioned.

How can we do the same on Android?

robingenz · 2025-10-06T10:36:21Z

@bakai-dev-team I haven't looked into it yet. It's part of the issue to find that out.

bakai-dev-team · 2025-10-22T06:52:52Z

@robingenz All done as you required.

Anyone who can check and confirm that it is works, you are welcome.

erlanz · 2025-11-05T09:43:44Z

@robingenz HI, could you please check PR, thanks

robingenz · 2025-11-08T13:13:49Z

PR is still failing.

erlanz · 2025-12-06T10:35:11Z

@robingenz Hello, fix lint, prettier. could you please check PR, thanks

pkg-pr-new · 2025-12-06T10:59:56Z

Open in StackBlitz

@capacitor-mlkit/barcode-scanning

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/barcode-scanning@300

@capacitor-mlkit/document-scanner

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/document-scanner@300

@capacitor-mlkit/face-detection

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/face-detection@300

@capacitor-mlkit/face-mesh-detection

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/face-mesh-detection@300

@capacitor-mlkit/selfie-segmentation

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/selfie-segmentation@300

@capacitor-mlkit/subject-segmentation

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/subject-segmentation@300

@capacitor-mlkit/translation

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/translation@300

commit: aa3b0a0

erlanz · 2025-12-10T07:11:14Z

@robingenz Hello, fix lint, prettier. could you please check PR, thanks

robingenz

Have you tested your implementation on all platforms?

robingenz · 2025-12-10T09:10:13Z

packages/barcode-scanning/src/definitions.ts

+  /**
+   * Pause scanning for barcodes.
+   *
+   * @since 7.3.1


Suggested change

* @since 7.3.1

* @since 7.5.0

If we manage to release it this week, it would be version 7.5.0.

robingenz · 2025-12-10T09:10:28Z

packages/barcode-scanning/src/definitions.ts

+  /**
+   * Resume scanning for barcodes.
+   *
+   * @since 7.3.1


Suggested change

* @since 7.3.1

* @since 7.5.0

If we manage to release it this week, it would be version 7.5.0.

robingenz · 2025-12-10T09:19:11Z

packages/barcode-scanning/src/web.ts

+    if (!this.videoElement) {
+      throw new Error(this.errorVideoElementMissing);
+    }
+    if (!this.stream) {
+      throw new Error('Stream is not available, call startScan first.');
+    }


The plugin should behave the same on all platforms. It should either return an error on Android or iOS as well, or on none on all platforms.

@bakai-dev-team This is still open.

robingenz · 2025-12-30T13:56:25Z

packages/barcode-scanning/src/definitions.ts

+  /**
+   * Pause scanning for barcodes.
+   *
+   * @since 7.5.0


Suggested change

* @since 7.5.0

* @since 8.1.0

Next version will be 8.1.0.

robingenz · 2025-12-30T13:56:39Z

packages/barcode-scanning/src/definitions.ts

+  /**
+   * Resume scanning for barcodes.
+   *
+   * @since 7.5.0


Suggested change

* @since 7.5.0

* @since 8.1.0

robingenz · 2025-12-30T13:57:47Z

packages/barcode-scanning/tsconfig.json

    "strict": true,
-    "target": "es2017"
+    "target": "es2017",
+    "types": []


Please revert that change. It's not related to this feature. You may need to install the latest version of @types/node as dev dependency if you have type issues.

robingenz · 2025-12-30T13:57:56Z

packages/barcode-scanning/src/web.ts


  async isSupported(): Promise<IsSupportedResult> {
-    return { supported: this._isSupported };
+    return {supported: this._isSupported};


Please format the code correctly and run npm run fmt.

robingenz · 2025-12-30T13:58:30Z

packages/barcode-scanning/src/web.ts

+    if (!this.videoElement) {
+      throw new Error(this.errorVideoElementMissing);
+    }
+    if (!this.stream) {
+      throw new Error('Stream is not available, call startScan first.');
+    }


@bakai-dev-team This is still open.

qliqdev added 3 commits September 7, 2025 16:59

commit for local install

7261a29

commit for local install

ffc21ec

ios fix

699ef3e

bakai-dev-team changed the title ~~FEAT: Pause and Resume Scan on CAP 7~~ feat(barcode-scanning): pause and resume scan feature, cap 7 Sep 9, 2025

android fix

679733d

qliqdev force-pushed the main branch from 471da4e to 679733d Compare October 22, 2025 06:49

erlanz and others added 2 commits December 6, 2025 16:23

fix lint, prettier

1563024

Merge branch 'main' into main

aa3b0a0

robingenz requested changes Dec 10, 2025

View reviewed changes

yryskeldi0101 and others added 2 commits December 30, 2025 12:44

fixed errors in all platforms

54f5f65

Merge branch 'main' into main

d8fdc94

bakai-dev-team requested a review from robingenz December 30, 2025 06:53

robingenz requested changes Dec 30, 2025

View reviewed changes

Uh oh!

feat(barcode-scanning): pause and resume scan feature, cap 7 #300

Are you sure you want to change the base?

feat(barcode-scanning): pause and resume scan feature, cap 7 #300

Uh oh!

Conversation

bakai-dev-team commented Sep 7, 2025

Pull request checklist

Uh oh!

matthiasschwarz commented Sep 7, 2025

Uh oh!

bakai-dev-team commented Sep 9, 2025

On Android

On iOS

Uh oh!

robingenz commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bakai-dev-team commented Oct 6, 2025

Uh oh!

robingenz commented Oct 6, 2025

Uh oh!

bakai-dev-team commented Oct 22, 2025

Uh oh!

erlanz commented Nov 5, 2025

Uh oh!

robingenz commented Nov 8, 2025

Uh oh!

erlanz commented Dec 6, 2025

Uh oh!

pkg-pr-new bot commented Dec 6, 2025

Uh oh!

erlanz commented Dec 10, 2025

Uh oh!

robingenz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

robingenz commented Sep 9, 2025 •

edited

Loading