Conversation
Contributor
I think that's a great idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a staging deployment for pushes on
main. I also set org-wide defaults forCF_API,CF_ORG,CF_SPACE,CF_USERNAME, andCF_PASSWORDfor ourcapireorg. View them here.For demonstration purposes I created a PR deployment (after merging this PR we only re-deploy for pushes on
main).Deployment + App Link: https://github.com/capire/samples/deployments/Staging
Workflow run: https://github.com/capire/samples/actions/runs/16520349169/job/46720555138
→ works
The workflow and actions are exactly the ones created by
cds add github-actionsexcept that I had to adapt the lines fetching the server logs for the microservices setup.Small heads-up: I had to add
@sap/cds-dktodevDependenciesfornpx cds upto find thecdsexecutable. This blows up ourpackage-lock.jsonquite a bit. If we want to keep it lean we could usenpm add @sap/cds-dkin the deployment workflow, but most stakeholders prefer to also freeze@sap/cds-dk.In the future, we could also offer the actions on the GitHub Actions marketplace, essentially reducing this PR to a single file of 46 LoC.