capnp-rpc: Add disconnect_background to Disconnector#581
Open
griff wants to merge 1 commit intocapnproto:masterfrom
Open
capnp-rpc: Add disconnect_background to Disconnector#581griff wants to merge 1 commit intocapnproto:masterfrom
griff wants to merge 1 commit intocapnproto:masterfrom
Conversation
This adds a public disconnect_background function to Disconnector so that you can signal it to disconnect but not have to wait for it to do so.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 51.64% 50.65% -1.00%
==========================================
Files 69 70 +1
Lines 33735 32295 -1440
==========================================
- Hits 17422 16358 -1064
+ Misses 16313 15937 -376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a public
disconnect_backgroundfunction toDisconnectorso that you can signal it to disconnect but not have to wait for it to do so.I usually run the
RpcSystemwithspawn_localand would like to be able to just signal that it should shut down in like aDropimplementation for my Client.It would also make my graceful shutdown listener for the server slightly less clunky since that needs to do this:
While with this PR it would look like this: