silent overflow of run_word_count when casting to 1 byte#622
Merged
dwrensha merged 2 commits intocapnproto:masterfrom Feb 18, 2026
Merged
silent overflow of run_word_count when casting to 1 byte#622dwrensha merged 2 commits intocapnproto:masterfrom
dwrensha merged 2 commits intocapnproto:masterfrom
Conversation
8787ee8 to
675a21e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 51.64% 50.98% -0.66%
==========================================
Files 69 71 +2
Lines 33735 32479 -1256
==========================================
- Hits 17422 16559 -863
+ Misses 16313 15920 -393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async PackedWrite was missing the 1-byte limiting that was in sync packed write.
capnproto-rust/capnp/src/serialize_packed.rs
Line 383 in 2ae271a
capnproto-rust/capnp/src/serialize_packed.rs
Line 405 in 2ae271a