Skip to content

silent overflow of run_word_count when casting to 1 byte#622

Merged
dwrensha merged 2 commits intocapnproto:masterfrom
jordan-wu-97:async-run-word-count-overflow
Feb 18, 2026
Merged

silent overflow of run_word_count when casting to 1 byte#622
dwrensha merged 2 commits intocapnproto:masterfrom
jordan-wu-97:async-run-word-count-overflow

Conversation

@jordan-wu-97
Copy link
Contributor

async PackedWrite was missing the 1-byte limiting that was in sync packed write.

limit = in_word.offset(255);

limit = in_ptr.offset(255 * 8);

@jordan-wu-97 jordan-wu-97 marked this pull request as ready for review February 18, 2026 02:40
@jordan-wu-97 jordan-wu-97 force-pushed the async-run-word-count-overflow branch from 8787ee8 to 675a21e Compare February 18, 2026 02:43
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.98%. Comparing base (ab342b3) to head (675a21e).
⚠️ Report is 267 commits behind head on master.

Files with missing lines Patch % Lines
capnp-futures/src/serialize_packed.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   51.64%   50.98%   -0.66%     
==========================================
  Files          69       71       +2     
  Lines       33735    32479    -1256     
==========================================
- Hits        17422    16559     -863     
+ Misses      16313    15920     -393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dwrensha dwrensha merged commit 6b703cf into capnproto:master Feb 18, 2026
10 checks passed
@dwrensha
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants