Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1217@patch: Check if options are null. #1236

Merged

Conversation

zachlankton
Copy link
Contributor

Fixes #1217

There are some instances where observer.options appears to be null or undefined.

In addition to the issue detailed in #1217
I was also having issues with childList characterData and attributes

The change in this PR adds optional chaining to the affected code.

I believe this covers all code where if (observer.options.*) occurs.

@zachlankton
Copy link
Contributor Author

Hi @capricorn86 have you had a chance to peak at this? Pretty small change and fixes some bugs for me and @rothsandro

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zachlankton for your contribution! 🌟

@capricorn86 capricorn86 merged commit aa16292 into capricorn86:master Feb 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v13] Error: Cannot read properties of null (reading 'subtree')
2 participants