fix: [#1181] Refactor storage mock #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nStorage as Storage is the correct class to use
…o feat/update-storage-mock
…nStorage as Storage is the correct class to use
capricorn86
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Thank you for your contribution @frankdiw! 🌟
I removed the added classes LocalStorage and SessionStorage, as Storage is the correct class to use for the properties localStorage and sessionStorage according to spec.
Mozilla docs:
I also added some more tests to cover that adding properties to Storage won't break in the future.
|
By the way, sorry that it took such a long time before merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxed: #1181