Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1181] Refactor storage mock #1254

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

frankdiw
Copy link
Contributor

@frankdiw frankdiw commented Feb 5, 2024

FIxed: #1181

@frankdiw frankdiw requested a review from capricorn86 as a code owner February 5, 2024 06:58
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @frankdiw! 🌟

I removed the added classes LocalStorage and SessionStorage, as Storage is the correct class to use for the properties localStorage and sessionStorage according to spec.

Mozilla docs:

I also added some more tests to cover that adding properties to Storage won't break in the future.

@capricorn86 capricorn86 merged commit b5af02b into capricorn86:master Mar 21, 2024
3 checks passed
@capricorn86
Copy link
Owner

By the way, sorry that it took such a long time before merging!

@frankdiw frankdiw deleted the feat/update-storage-mock branch March 24, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object.keys(localStorage) returns ['_store'] not the keys stored
2 participants