[next][SuperH] Fix missing setting detail->sh #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested changes
Sep 1, 2024
There was a problem hiding this comment.
Thanks a lot! Really weird it hasn't been discovered before.
Please delete the binary.
The failing clang-tidy test is because there are unrelated problems.
I asked @lhsazevedo in #2389 already to fix it.
I you want to you can of course open a PR to his branch to speed things up.
detail->sh is never set. Which makes the detailed output related to operands is always missing. Signed-off-by: david942j <[email protected]>
david942j
force-pushed
the
next_sh_op
branch
from
7dc1d4f to
17b9a10
Compare
Rot127
approved these changes
Sep 9, 2024
|
Please rebase though and fix the conflicts. The clang-tidy job can be ignored. It is fixed in the coverity PR. |
|
@david942j The clang-tidy issues are fixed in #2469. But I cannot merge, so we have to wait until @kabeor finds time to review and merges stuff. |
|
@kabeor I just resolved conflicts with the latest next branch, this PR is ready to be reviewed, thanks! |
Rot127
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detail->sh is never set. Which makes the detailed output related to operands is always missing.
Your checklist for this pull request
Detailed description
detail->shis never set. Which makes the detailed output related to operands is always missing.Test plan
build/suite/cstest/cstest tests/issues/issues.yaml, the newly added case passes/fails with/without the change.Closing issues
closes #2424 (along with #2465)