Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tarball before DEB/RPM package. #2626

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Feb 17, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Because it was run after the RPM/DEB package build it contained the 'build' directory with all its files. Which made it way too big.

Test plan

https://github.com/Rot127/capstone/releases/tag/v300.0.2

Closing issues

...

Because it was run after the RPM/DEB package build it contained the 'build' directory
with all its files. Which made it way too big.
@Rot127
Copy link
Collaborator Author

Rot127 commented Feb 17, 2025

@kabeor This one definitely before the patch release please.

@kabeor kabeor merged commit 59cca4f into capstone-engine:v5 Feb 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants