Simplify regs_access #170
Merged
Simplify regs_access #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures cs_regs_access arguments are more clearly pointers to fixed-size arrays.
tmfink
force-pushed
the
regs-access-simplify
branch
from
7ad4ec7 to
74c97e9
Compare
When getting instruction details, we now eagerly call regs_access() to get "extended" read/write registers. This is simpler than requiring users to manually call it to get the "actual" accessed registers.
tmfink
force-pushed
the
regs-access-simplify
branch
from
74c97e9 to
78d8223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently users need to manually call
regs_access()method to get all accessed registers.Instead, it would be a much better experience for the underlying
cs_regs_access()function to be called as automatically.When complete, should address #84.