Fix zsh capture script exit code and redundant compinit - #326
Merged
Conversation
The capture script always returned exit code 2 because `return 0` inside the piped while-loop only exits the subshell, not the script. Since carapace's ActionExecCommand treats non-zero exits as errors and skips the output callback, this silently broke the zsh bridge on every invocation. Changed the unconditional `return 2` to `return 0`. Also merged the redundant double compinit call into a single call with the custom dump path, and fixed stray whitespace on the source line. Added deviation comments marking where this vendored copy diverges from upstream (Valodim/zsh-capture-completion). Assisted-by: Crush:glm-5.2
Coverage Report for CI Build 29171863713Coverage remained the same at 0.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capture script always returned exit code 2 because
return 0insidethe piped while-loop only exits the subshell, not the script. Since
carapace's ActionExecCommand treats non-zero exits as errors and skips
the output callback, this silently broke the zsh bridge on every
invocation. Changed the unconditional
return 2toreturn 0.Also merged the redundant double compinit call into a single call with
the custom dump path, and fixed stray whitespace on the source line.
Added deviation comments marking where this vendored copy diverges from
upstream (Valodim/zsh-capture-completion).
Assisted-by: Crush:glm-5.2