chore: add a11y scan to smoke tests #556
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ethanwinters
force-pushed
the
a11y-scan
branch
7 times, most recently
from
d3264b3 to
f57f49a
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
from
f57f49a to
36a4952
Compare
ethanwinters
requested review from
sangeethababu9223
and removed request for
annawen1
ethanwinters
force-pushed
the
a11y-scan
branch
from
36a4952 to
44c35ae
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
6 times, most recently
from
a75175c to
adf4ed9
Compare
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ethanwinters
force-pushed
the
a11y-scan
branch
7 times, most recently
from
f1b1dce to
304de5c
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
2 times, most recently
from
235230e to
8d6bde5
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
4 times, most recently
from
a913747 to
54df11a
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
2 times, most recently
from
a5f05f7 to
94cf4ac
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
2 times, most recently
from
29da78d to
24bfddc
Compare
ethanwinters
force-pushed
the
a11y-scan
branch
from
24bfddc to
9d7de96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple a11y fixes around minor markup fixes like missing labels, etc.
The bulk is adding in a11y scans to playright tests. They just throw warnings on a11y issues. Currently, the same warnings get duplicated over and over for shared components like the input field or whatever. This isn't super useful right now, but will serve as a baseline to make it useful. The next step will be to store a master list of known issues so they don't get repeated over and over and over again and we can start fixing the known issues and erroring out on new issues.