feat: improve mobile scrolling #709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ethanwinters
force-pushed
the
mobile-scrolling-fix
branch
from
549e5da to
0bf312b
Compare
Member
|
@ethanwinters Can you share a screen recording of the issue? I'm not sure if I'm noticing the same issue, I recorded this one from iOS Safari, but not sure if this is the same thing you're mentioning ScreenRecording_11-24-2025.14-54-37_1.MP4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous CSS only solution led to some strange results in Chrome for iOS including not being able to see the input field, and the ability the break everything across browsers by "overscrolling".
This PR introduces a new hook to manage freezing body scroll styles, and set the visual view port size based on JS measurements instead of CSS properties which could be unreliable on their own (especially in Chrome for iOS).
It also includes a change to generate isBrowser via function instead of a constant as it seemed like something were getting treeshaken away incorrectly. Finally, we had and extra
-in our phone style name.Testing instructions:
Do this in iOS Safari, iOS Chrome and Android.