Skip to content

fix: add tabindex to activedescendant #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akshat55 merged 9 commits into from
Jun 27, 2025
Merged

fix: add tabindex to activedescendant #3121

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19a6bc6
Merge branch 'carbon-design-system:master' into master
kush-savani Apr 2, 2024
db887e5
Merge branch 'carbon-design-system:master' into master
kush-savani Jun 20, 2024
63cfbbc
Merge branch 'carbon-design-system:master' into master
kush-savani Aug 6, 2024
4105fb3
Merge branch 'carbon-design-system:master' into master
kush-savani Jan 6, 2025
d4089f3
Merge branch 'carbon-design-system:master' into master
kush-savani Mar 10, 2025
c56690b
fix(dropdown-list): set ul element to focus able
kush-savani Mar 13, 2025
5646a63
Merge branch 'master' into dropdown-list-accessibility
Akshat55 Jun 18, 2025
2b330f7
Merge branch 'master' into dropdown-list-accessibility
Akshat55 Jun 26, 2025
611464d
fix: add tabindex to activedescendant
Akshat55 Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dropdown/list/dropdown-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ import { ScrollCustomEvent } from "./scroll-custom-event.interface";
class="cds--list-box__menu cds--multi-select"
(scroll)="emitScroll($event)"
(keydown)="navigateList($event)"
tabindex="-1"
tabindex="0"
[attr.aria-label]="ariaLabel"
[attr.aria-activedescendant]="highlightedItem">
<li
Expand All @@ -67,6 +67,7 @@ import { ScrollCustomEvent } from "./scroll-custom-event.interface";
class="cds--list-box__menu-item"
[attr.aria-selected]="item.selected"
[id]="getItemId(i)"
[attr.tabindex]="highlightedItem === getItemId(i) ? 0 : null"
[attr.title]=" showTitles ? item.content : null"
[attr.disabled]="item.disabled ? true : null"
[ngClass]="{
Expand Down
Loading