Skip to content

fix(dialog): Remove the incorrect descendant element #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thejashwini123
Copy link

@Thejashwini123 Thejashwini123 commented Apr 2, 2025

closes : #3126

Violation : The element with role "button" contains descendants with roles "dialog" which are ignored by browsers

Before
accessibility-violation

After
after

Issue : The accessibility violation occurs because aria-owns moves the dialog inside the button in the accessibility tree, which is not valid for a button element.

Carbon version : 5.57.1

@Thejashwini123 Thejashwini123 requested a review from a team as a code owner April 2, 2025 08:25
Copy link

github-actions bot commented Apr 2, 2025

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
@Akshat55
@thejashwini S
Thejashwini S seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit decee9c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6807c164fa6d550008f616b6
😎 Deploy Preview https://deploy-preview-3125--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Thejashwini123
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

@Thejashwini123
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants