fix(data-table): preserve active filter when rows prop changes#2944
Merged
fix(data-table): preserve active filter when rows prop changes#2944
rows prop changes#2944Conversation
0d2c94c to
ee8432d
Compare
ee8432d to
f8326be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ToolbarSearch(or any consumer) callsfilterRows, the visible rows are stored in$tableRowswhileoriginalRowskeeps the full set. As soon as the parent re-assignsrows(e.g. after a fetch), the reactive resetsoriginalRows = [...rows]; $tableRows = rows;and the user's search is wiped without warning, even though the search input still shows the query.The fix is to track the last
filterRowsinputs and replay them whenrowsis reassigned, so consumers callingfilterRowsvia context don't silently lose the filter on row updates.Svelte REPL repro: https://svelte.dev/playground/a43647f2061240ec9ef6b4852b15ca95?version=latest