Skip to content

Conversation

@tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 31, 2025

This updates the repo's configuration and usage of node.

Changelog

New

  • add .nvmrc for centralized node version management

Changed

  • update repo to use node v24.11.0 for local dev
  • update ci to use .nvmrc instead of hardcoded (outdated/EOL v18) version
  • update ci workflows to latest versions and pin them to SHA's for best security practice

Testing / Reviewing

  • CI should pass, storybooks should run

@tay1orjones tay1orjones requested review from a team as code owners October 31, 2025 15:53
@tay1orjones tay1orjones requested review from kennylam and riddhybansal and removed request for a team October 31, 2025 15:53
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-web-components/deploys/6904de91b382b5457e7c1388
😎 Deploy Preview https://deploy-preview-901--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for carbon-labs-react failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/carbon-labs-react/deploys/6908e6a9c3abc9f6c392931f

@tay1orjones tay1orjones self-assigned this Oct 31, 2025
@tay1orjones tay1orjones moved this to 🚦 In Review in Design System Oct 31, 2025
@tay1orjones tay1orjones changed the title chore(node): update to node v24.11.0 chore(node): update carbon-labs to node v24.11.0 Oct 31, 2025
@tay1orjones tay1orjones requested review from alisonjoseph and removed request for riddhybansal October 31, 2025 15:55
@alisonjoseph
Copy link
Member

@tay1orjones the React deploy keeps failing for some reason 🤔

@tay1orjones
Copy link
Member Author

tay1orjones commented Nov 4, 2025

Yeah - we should hold off on this. We've found that workflows fail in the monorepo and we're reverting to v22 until all the actions are updated to use 24.

I'll update this PR to 22 instead.

@tay1orjones tay1orjones marked this pull request as draft November 4, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🚦 In Review

Development

Successfully merging this pull request may close these issues.

2 participants