-
Notifications
You must be signed in to change notification settings - Fork 47
fix: utilities exports #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: utilities exports #927
Conversation
❌ Deploy Preview for carbon-labs-react failed. Why did it fail? →
|
✅ Deploy Preview for carbon-labs-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@alisonjoseph @ariellalgilmore I know we've had fun with exports before so I thought I'd try and split this up into the change required to @carbon-labs/utilities which is preventing adoption of Typescript in the Carbon-react-router-template project. The second PR will address the 121 direct imports of |
04a9cc3 to
0a5561e
Compare
alisonjoseph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, would like to get one more set of eyes on it before merging. @annawen1 are you able to take a quick look?
Contributes to #923
This is PR 1 of 2, which makes changes to the utilities package exports.
What This Achieves
Makes @carbon-labs/utilities fully TypeScript-compatible. TypeScript projects can now import from this package with full type safety and IDE autocomplete. All existing JavaScript consumers continue to work unchanged.
Corrects the rollup resolution that was incorrectly using the selecting the src folder of @carbon-labs/utilities.
PR 2 will
e.g.
{ "peerDependencies": { "@carbon-labs/utilities": "^0.17.0" } }Testing / Reviewing
The build still runs.