docs(text-input): update password input read-only documentation #4760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subham-KRLX
had a problem deploying
to
Preview
GitHub Actions
Failure
alina-jacob
requested changes
Jan 9, 2026
Member
alina-jacob
left a comment
alina-jacob
left a comment
There was a problem hiding this comment.
Hi there @Subham-KRLX, thanks for working on this!
A couple of things
- The website change in the usage tab is incorrect. This issue resolves the fact that the 'eye/visibility' toggle button is now enabled even in read-only states. So this edit can be entirely skipped.
- Issue #4757 highlights the need to make changes in the style tab so this PR doesn't fulfill that requirement yet.
Contributor
Author
|
Hi @alina-jacob thanks for the review I have reverted the changes to usage.mdx since the toggle is enabled in read-only state. I have also reviewed the Style tab and since the toggle follows the standard enabled interaction I haven't added specific 'disabled' documentation. Please let me know if any other specific visual specs need to be listed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4757
Updated the Password Input documentation to reflect that the visibility toggle is disabled in the read-only state and added a corresponding Storybook demo variant.
Changelog
New
Added "Password Input (Read only)" variant to the Storybook demo in
code.mdx
.
Changed
Updated
usage.mdx
to explicitly state that the password visibility toggle is disabled when the input is read-only.
Removed
None