-
Notifications
You must be signed in to change notification settings - Fork 863
feat: syntax highlighting tokens #4762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We'll merge this in after carbon-design-system/carbon#21047 has been reviewed and merged into the Carbon repo |
laurenmrice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annawen1 this looks great. One question about the heading and anchor link though, would you mind if we called this "Syntax highlight" instead? I only say this because we have a $highlight color token in our Misc section and want to be super specific that there is a difference.
|
@laurenmrice I went ahead and just renamed it to Pushed up changes with the additional tokens that were missed in the initial PRs! |
laurenmrice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Contributes to carbon-design-system/carbon-ai-chat#549
Adds syntax highlighting tokens to the color tokens page
Elements > Color > Core Tokens > Syntax
Changelog
New