fix(live demo): update live labels and add feature flag toggle #4780
Conversation
alisonjoseph
requested review from
Kritvi-bhatia17,
devadula-nandan,
laurenmrice and
sangeethababu9223
Kritvi-bhatia17
left a comment
Kritvi-bhatia17
left a comment
There was a problem hiding this comment.
The PR looks good to me, Alison!
One small thing I wanted to discuss: while reviewing this PR, I noticed that the feature flag in the toggle applies to both sizes. This isn’t coming across well in the live demo because we currently have a size prop in Storybook instead of separate stories for the two different sizes.
Do you think there’s a possible workaround for that? Would removing the default from the live demo for the feature flag story help, or could we create two separate stories in Storybook so it reflects better in the live demo as well?
|
@Kritvi-bhatia17 We would need to create two different stories in order to show in the live demo. So I suppose we would need to decide if thats something we want to do here. We don't really do this for most other components/props. |
Yeah, you’re right. Generally, we use size as a prop rather than creating another story. So I think the devs can decide whether the toggle without the feature flag should simply have a size prop instead of two different stories if that isn't a breaking change, which would also solve the problem. Alternatively, we could add two stories within the toggle with the feature flag. |
|
@Kritvi-bhatia17 You're able to toggle the small size prop currently in the storybook. Am I good to merge this PR in? I think this should be ok, if we want to add anything in the future we can do that. |
3 participants
Closes #4683
Changelog
New
Changed