fix(RadioTile): ensure aria attributes apply to input instead of label #21068
Conversation
|
Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 2nikhiltom seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21068 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 515 515
Lines 38220 38223 +3
Branches 5861 5867 +6
=======================================
+ Hits 35392 35395 +3
Misses 2678 2678
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
1 participant
Closes #20496
Apply aria-describedby and aria-labelledby to the input element in RadioTile
Changelog
Updated RadioTile so aria-describedby and aria-labelledby are applied to the underlying instead of the to improving screen reader support
Changed
{...(ariaDescribedBy && { 'aria-describedby': ariaDescribedBy })}
{...(ariaLabelledBy && { 'aria-labelledby': ariaLabelledBy })}
New
Added test cases against the fix
Testing / Reviewing
Render RadioTile with aria-describedby and/or aria-labelledby.
Confirm accessibility attributes are applied only to the element and not the
Check new test cases are passing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Updated documentation and storybook examplesMore details can be found in the pull request guide