-
Notifications
You must be signed in to change notification settings - Fork 150
feat: truncated text initial commit web component #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: truncated text initial commit web component #7397
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7397 +/- ##
==========================================
+ Coverage 83.94% 84.35% +0.41%
==========================================
Files 425 427 +2
Lines 17218 17357 +139
Branches 4545 4580 +35
==========================================
+ Hits 14453 14641 +188
+ Misses 2765 2716 -49
🚀 New features to boost your workflow:
|
import { property, query } from 'lit/decorators.js'; | ||
import { carbonElement as customElement } from '@carbon/web-components/es/globals/decorators/carbon-element.js'; | ||
import { prefix } from '../../globals/settings'; | ||
// todo: replace with definition tooltip to get tab stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definition tooltip is not released in carbon/web-components yet.
we could leave this as it is as well.
IMO we don't need a tab stop on string formatter, as it could potentially cause inconsistencies in tab order in some tests. however we could still access it with mouse or touch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a full review, but I know @davidmenendez was considering something like useOverflowString
, but maybe that’s more for utility format.
I do think this should be classified as a utility component. But I’d love for us to consider the naming if there are better ways to describe its purpose.
(Maybe @RichKummer has thoughts?)
Also we should label this a feat
not a chore
:D
# FullPageError | ||
|
||
Display a full-page error when the requested page is unavailable to the user. | ||
This is typically caused by issues with the requested URL or access permissions. | ||
Errors caused by server connectivity issues are not covered in this guideline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this. :)
ah, the framework agonistic utility, let me try that parallel. sounds like a good idea to me. |
|
i have updated this pr, and the changes include. name change to tests will be fixed soon |
Hi @RichKummer, All the changes are done. and the team decided to go with Needed design inputs
another viable option to replace
In contrast, the tooltip variant requires users to reorient themselves after opening the tooltip, they often need to reread the entire text to find where they left off, which can disrupt comprehension. The deploy preview is ready to test. CC: @elycheea |
Hey @devadula-nandan ! Tooltip
Expand
![]() |
it could be an accessibility choice, and we can pass this to accessibility team to get the expected behavior, ill make it tabbable in this pr for now.
i couldn't find the corresponding tokens in the library for the exact vales mentioned, so i have used the nearest available match.
removed the gradient as per discussion |
Closes #7542
adds truncated text in web components
What did you change?
added new web component
How did you test and verify your work?
setup basic test, test coverage of at least 80% will be covered in #7541