Skip to content

feat(DeleteAndRemovePattern): deletion and removal patterns using carbon web components #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 21, 2025

Conversation

szinta
Copy link
Contributor

@szinta szinta commented May 8, 2025

Closes #7371 , #7369 and #7474

Created below patterns using carbon web components:

  • Default variant of high impact deletion pattern
  • High impact deletion with connected items
  • High impact batch deletion
  • Medium impact deletion/removal patterns
  • Low impact deletion/removal patterns

What did you change?

  • packages/ibm-products-web-components/examples/delete-and-remove
  • packages/ibm-products-web-components/src/patterns/delete-and-remove

How did you test and verify your work?

  • Storybook
  • yarn run dev from examples/delete-and-remove folder
  • Stackblitz

Note: This pull request is a duplicate of PR #7433 . I am closing the original PR due to a DCO error that I am unable to resolve.

@szinta szinta requested a review from a team as a code owner May 8, 2025 06:27
@szinta szinta requested review from matthewgallo and jlongshore and removed request for a team May 8, 2025 06:27
Copy link

netlify bot commented May 8, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit f842091
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/682da1c4dfe4db000859edf1
😎 Deploy Preview https://deploy-preview-7473--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 8, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit f842091
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/682da1c4c744350008a51860
😎 Deploy Preview https://deploy-preview-7473--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@szinta szinta requested review from elycheea and anamikaanu96 and removed request for jlongshore May 8, 2025 06:27
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (0661e08) to head (f842091).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7473      +/-   ##
==========================================
- Coverage   84.45%   84.44%   -0.02%     
==========================================
  Files         425      425              
  Lines       17232    17232              
  Branches     4564     4564              
==========================================
- Hits        14553    14551       -2     
- Misses       2679     2681       +2     
Components Coverage Δ
ibm-products 81.99% <ø> (-0.02%) ⬇️
ibm-products-web-components 92.14% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szinta szinta requested a review from anamikaanu96 May 9, 2025 06:17
@szinta szinta added the status: WIP work in progress label May 12, 2025
@szinta szinta marked this pull request as draft May 12, 2025 12:28
@szinta szinta removed the status: WIP work in progress label May 13, 2025
@szinta szinta marked this pull request as ready for review May 13, 2025 10:47
matthewgallo
matthewgallo previously approved these changes May 20, 2025
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great! I like how the stack blitz clearly lays out all the different examples.

@matthewgallo matthewgallo added this pull request to the merge queue May 21, 2025
Merged via the queue into carbon-design-system:main with commit 87ac33e May 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create deletion pattern for Web Components
4 participants