-
Notifications
You must be signed in to change notification settings - Fork 151
feat(openStackblitz): about modal and export Modal #7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openStackblitz): about modal and export Modal #7479
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7479 +/- ##
==========================================
+ Coverage 84.45% 84.48% +0.03%
==========================================
Files 425 425
Lines 17235 17247 +12
Branches 4564 4575 +11
==========================================
+ Hits 14555 14571 +16
+ Misses 2680 2676 -4
🚀 New features to boost your workflow:
|
packages/ibm-products/src/components/ExportModal/ExportModal.mdx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/AboutModal/AboutModal.stories.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things, we've lost the "usage guidelines" link at the top of the docs page for both.
Also, for the product logos in about modal, lets use either all hosted urls or all base64 encoded images.
Hey @sangeethababu9223 and @matthewgallo, Thanks for reviewing! Done the changes! For the product logos, it seems that Webpack is converting the images to either Base64 or hosted URLs based on their file size. I got these from the inspect window. In the case of Grafana and Ansible logo's, their sizes exceed 70KB, which is likely why they are being served as hosted URLs instead of being inlined as Base64. If we want the images to be either hosted URLs or Base64, we could consider working with a designer to optimize and reduce the file sizes. Please suggest if you have any idea. |
f0f0427
Closes #7175
Implemented open stackblitz in About Modal and Export Modal
What did you change?
Created
packages/ibm-products/src/components/AboutModal/AboutModal.mdx and
packages/ibm-products/src/components/ExportModal/ExportModal.mdx
Updated
packages/ibm-products/src/components/AboutModal/AboutModal.stories.jsx
packages/ibm-products/src/components/ExportModal/ExportModal.stories.jsx
e2e/components/AboutModal/AboutModal-test.avt.e2e.js
How did you test and verify your work? yarn storybook and open stackblitz (Without the changes to codePreviewer.tsx from 7365, this PR cannot be tested in the deployment preview.)
Note: This PR should only be merged after 7365
Therefore, marking it as a draft until 7365 is merged.