Skip to content

feat(openStackblitz): about modal and export Modal #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anamikaanu96
Copy link
Contributor

@anamikaanu96 anamikaanu96 commented May 9, 2025

Closes #7175

Implemented open stackblitz in About Modal and Export Modal

What did you change?

Created
packages/ibm-products/src/components/AboutModal/AboutModal.mdx and
packages/ibm-products/src/components/ExportModal/ExportModal.mdx

Updated
packages/ibm-products/src/components/AboutModal/AboutModal.stories.jsx
packages/ibm-products/src/components/ExportModal/ExportModal.stories.jsx
e2e/components/AboutModal/AboutModal-test.avt.e2e.js

How did you test and verify your work? yarn storybook and open stackblitz (Without the changes to codePreviewer.tsx from 7365, this PR cannot be tested in the deployment preview.)

Note: This PR should only be merged after 7365
Therefore, marking it as a draft until 7365 is merged.

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner May 9, 2025 11:41
@anamikaanu96 anamikaanu96 requested review from matthewgallo and devadula-nandan and removed request for a team May 9, 2025 11:41
Copy link

netlify bot commented May 9, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 7a41a4d
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/6836de69f34cfa0008d75ece
😎 Deploy Preview https://deploy-preview-7479--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 9, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 7a41a4d
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/6836de69910fa70008d05767
😎 Deploy Preview https://deploy-preview-7479--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@anamikaanu96 anamikaanu96 marked this pull request as draft May 9, 2025 11:42
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (910b7ed) to head (7a41a4d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7479      +/-   ##
==========================================
+ Coverage   84.45%   84.48%   +0.03%     
==========================================
  Files         425      425              
  Lines       17235    17247      +12     
  Branches     4564     4575      +11     
==========================================
+ Hits        14555    14571      +16     
+ Misses       2680     2676       -4     
Components Coverage Δ
ibm-products 82.05% <ø> (+0.04%) ⬆️
ibm-products-web-components 92.14% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anamikaanu96 anamikaanu96 marked this pull request as ready for review May 21, 2025 05:39
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things, we've lost the "usage guidelines" link at the top of the docs page for both.

Also, for the product logos in about modal, lets use either all hosted urls or all base64 encoded images.

@anamikaanu96
Copy link
Contributor Author

Hey @sangeethababu9223 and @matthewgallo, Thanks for reviewing! Done the changes!

For the product logos, it seems that Webpack is converting the images to either Base64 or hosted URLs based on their file size. I got these from the inspect window. In the case of Grafana and Ansible logo's, their sizes exceed 70KB, which is likely why they are being served as hosted URLs instead of being inlined as Base64.

If we want the images to be either hosted URLs or Base64, we could consider working with a designer to optimize and reduce the file sizes. Please suggest if you have any idea.

@anamikaanu96 anamikaanu96 added this pull request to the merge queue May 30, 2025
Merged via the queue into carbon-design-system:main with commit f0f0427 May 30, 2025
32 of 33 checks passed
@anamikaanu96 anamikaanu96 deleted the openStackblitzModal branch May 30, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Open Stackblitz in About Modal and Export Modal
3 participants