-
Notifications
You must be signed in to change notification settings - Fork 151
fix: ProductiveCard - actionIcons doesn't include types for data attributes #7486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: ProductiveCard - actionIcons doesn't include types for data attributes #7486
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7486 +/- ##
=======================================
Coverage 84.50% 84.50%
=======================================
Files 425 425
Lines 17288 17288
Branches 4589 4589
=======================================
+ Hits 14609 14610 +1
+ Misses 2679 2678 -1
🚀 New features to boost your workflow:
|
@@ -5,7 +5,12 @@ | |||
// LICENSE file in the root directory of this source tree. | |||
// | |||
|
|||
import React, { PropsWithChildren, ReactNode, forwardRef } from 'react'; | |||
import React, { | |||
HTMLAttributes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this is used anymore, you can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlongshore We should be good to merge this after this small change ^^
Closes #6909
actionIcons prop wouldn't allow for data attributes.
What did you change?
In Card.tsx, there is a type for ActionIcon - I extended that interface further by adding
HTMLAttributes<HTMLElement>
How did you test and verify your work?
Wrote an additional test
Storybook