fix: ProductiveCard - actionIcons doesn't include types for data attributes #7486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlongshore
requested review from
matthewgallo and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7486 +/- ##
=======================================
Coverage 84.50% 84.50%
=======================================
Files 425 425
Lines 17288 17288
Branches 4589 4589
=======================================
+ Hits 14609 14610 +1
+ Misses 2679 2678 -1
🚀 New features to boost your workflow:
|
matthewgallo
previously approved these changes
May 13, 2025
| @@ -5,7 +5,12 @@ | |||
| // LICENSE file in the root directory of this source tree. | |||
| // | |||
|
|
|||
| import React, { PropsWithChildren, ReactNode, forwardRef } from 'react'; | |||
| import React, { | |||
| HTMLAttributes, | |||
There was a problem hiding this comment.
Don't think this is used anymore, you can remove it.
There was a problem hiding this comment.
@jlongshore We should be good to merge this after this small change ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6909
actionIcons prop wouldn't allow for data attributes.
What did you change?
In Card.tsx, there is a type for ActionIcon - I extended that interface further by adding
HTMLAttributes<HTMLElement>How did you test and verify your work?
Wrote an additional test
Storybook