Skip to content

fix: ProductiveCard - actionIcons doesn't include types for data attributes #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jlongshore
Copy link
Contributor

Closes #6909

actionIcons prop wouldn't allow for data attributes.

What did you change?

In Card.tsx, there is a type for ActionIcon - I extended that interface further by adding HTMLAttributes<HTMLElement>

How did you test and verify your work?

Wrote an additional test
Storybook

@jlongshore jlongshore requested a review from a team as a code owner May 9, 2025 22:26
@jlongshore jlongshore requested review from matthewgallo and anamikaanu96 and removed request for a team May 9, 2025 22:26
Copy link

netlify bot commented May 9, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 605b769
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/6841c057b562df00087a481d
😎 Deploy Preview https://deploy-preview-7486--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 9, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 605b769
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/6841c05774972400081fda4f
😎 Deploy Preview https://deploy-preview-7486--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (64a65c2) to head (605b769).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7486   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         425      425           
  Lines       17288    17288           
  Branches     4589     4589           
=======================================
+ Hits        14609    14610    +1     
+ Misses       2679     2678    -1     
Components Coverage Δ
ibm-products 82.09% <ø> (+<0.01%) ⬆️
ibm-products-web-components 92.14% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matthewgallo
matthewgallo previously approved these changes May 13, 2025
@@ -5,7 +5,12 @@
// LICENSE file in the root directory of this source tree.
//

import React, { PropsWithChildren, ReactNode, forwardRef } from 'react';
import React, {
HTMLAttributes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is used anymore, you can remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlongshore We should be good to merge this after this small change ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProductiveCard actionIcons doesn't include types for data attributes
3 participants