-
Notifications
You must be signed in to change notification settings - Fork 3
sId, deletedAt columns addition and pagination offSet fix #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5dd9095 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update interfaces and types with optional properties as well for this to work properly
I have shared my reasons on why I do not agree with the The pagination offset was purposefully built in this way to be 0-index based rather than 1-index based (as is mentioned in the comments in the file). While I do recognize the utility of 1-index based calculation (which is why I added offset1 which is still part of the commented out code), it didn't make the final cut as the 0-index based calculations are simpler and more consistent with the ecosystem and with cursor based pagination systems, which means easier interop with the persistence mechanisms and the third party APIs being utilized. I mean, it is much easier to add Having 10 as the default page size is probably reasonable (although very low, increasing the number of unnecessary requests). To be honest, the default options aren't really meant to be used as it is better to be explicit when creating the pagination options, ideally with both the |
No description provided.