chore: [LOB-1806] Reconciliation indexer endpoint#526
chore: [LOB-1806] Reconciliation indexer endpoint#526M4rc0Russ0 wants to merge 3 commits intorelease/1.3.0from
Conversation
M4rc0Russ0
force-pushed
the
chore/LOB-1806_reconciliation_indexer_endpoint
branch
3 times, most recently
from
8c2bfeb to
c9bb82d
Compare
| private final String baseUrl; | ||
| private final int pageSize; | ||
|
|
||
| public OnChainIndexerClient(ObjectMapper objectMapper, RestClient restClient, String baseUrl) { |
There was a problem hiding this comment.
With RequiredArgsConstructor you don't need to specify it yourself.
|
|
||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| public class OnChainIndexerClient { |
There was a problem hiding this comment.
You could rename it to OnChainIndexerService and move it to service or make a subfolder within service called client or indexer. Just trying to avoid changing the base folder structure to much.
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public record OnChainTransactionDto( |
There was a problem hiding this comment.
Could you move this to our dto folder?
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public record OnChainTransactionItemDto( |
There was a problem hiding this comment.
Same. Please move to dto folder
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| public record OnChainTransactionSearchRequest( |
There was a problem hiding this comment.
We probably also have a folder where all requests are located
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public record OnChainTransactionsPageResponse( |
|
|
||
| // Get data from indexer for the chunk transactions | ||
| Either<Problem, Map<String, IndexerReconcilationServiceIF.IndexerReconcilationResult>> resultE = | ||
| indexerReconcilationService.get().reconcileWithIndexer( |
There was a problem hiding this comment.
You need to do here indexerReconcilationService.orElseThrow() and throw an exception or handle the situation that you don't have an indexer differently.
M4rc0Russ0
force-pushed
the
chore/LOB-1806_reconciliation_indexer_endpoint
branch
3 times, most recently
from
7bd99a0 to
e0cf37c
Compare
|
M4rc0Russ0
force-pushed
the
chore/LOB-1806_reconciliation_indexer_endpoint
branch
2 times, most recently
from
91f5e78 to
14902c5
Compare
source : CSV
M4rc0Russ0
force-pushed
the
chore/LOB-1806_reconciliation_indexer_endpoint
branch
from
5e046e2 to
0963142
Compare
M4rc0Russ0
force-pushed
the
chore/LOB-1806_reconciliation_indexer_endpoint
branch
from
0963142 to
0e05e41
Compare
2 participants
No description provided.