Skip to content

feat(ui): Whitelabelling of terms of use and privacy policy #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sdisalvo-crd
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd commented May 22, 2025

Description

Refactoring the language file to extract some parts into dedicated files for maintainability.

After merging this we will wait for Legal and add the new updated text to the UNDP branch.

Checklist before requesting a review

Issue ticket number and link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Browser (Showing that the text is still being replaced correctly - I also tested on emulators)

22052025155919.mp4

@sdisalvo-crd sdisalvo-crd self-assigned this May 22, 2025
@sdisalvo-crd sdisalvo-crd marked this pull request as ready for review May 22, 2025 15:04
@sdisalvo-crd sdisalvo-crd requested a review from jorgenavben May 22, 2025 15:23
jorgenavben
jorgenavben previously approved these changes May 22, 2025
@sdisalvo-crd sdisalvo-crd merged commit 0575fa8 into main May 28, 2025
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-2239-Whitelabelling-of-terms-of-use-and-privacy-policy branch May 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants