Skip to content

Conversation

@Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 4, 2025

Description

Invalid connect URL if KERIA is down

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: VT20-2329

Testing & Validation

  • This PR has been tested/validated in iOS, Android and browser.
  • Added new unit tests, if relevant.

Design Review

  • In case this PR contains changes to the UI, add some screenshots and/or videos to show the changes on relevant devices.

Recovery Flow

Screen.Recording.2025-12-11.at.10.33.52.mov

Boot Flow

Screen.Recording.2025-12-11.at.10.19.21.mov

@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Dec 4, 2025
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not entirely sure. Waiting to see if @iFergal has any comments on this.

@sdisalvo-crd sdisalvo-crd self-requested a review December 15, 2025 11:59
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@iFergal iFergal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from core/logic side

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the VT20-2329-invalid-connect-url-if-keria-is-down branch from 2b5842c to 227cea9 Compare December 17, 2025 07:49
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Entering something like this https://dev.keria.cf-keripy.metadata.dev.cf-deployments.org works fine, please add a video.

  2. Adding this https://keria-boot.dev.idw-sandboxes.cf-deployments.org shows a wrong message. Please fix and share video.

@sdisalvo-crd sdisalvo-crd self-requested a review December 17, 2025 09:56
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the VT20-2329-invalid-connect-url-if-keria-is-down branch from 227cea9 to ae1328f Compare December 17, 2025 10:36
@sdisalvo-crd sdisalvo-crd merged commit 22a8fc2 into develop Dec 17, 2025
3 checks passed
@jacklesotatek
Copy link
Collaborator

Tests passed on this branch. Thanks

@jacklesotatek jacklesotatek deleted the VT20-2329-invalid-connect-url-if-keria-is-down branch December 19, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants