fix(ui): Omitted profiles shown in group list while setting group up by Sotatek-DukeVu · Pull Request #1568 · cardano-foundation/veridian-wallet

Sotatek-DukeVu · 2026-01-30T08:41:47Z

Description

Omitted profiles shown in group list while setting group up

Checklist before requesting a review

Issue ticket number and link

This PR has a valid ticket number or issue: VT20-2574, VT20-2573

Testing & Validation

This PR has been tested/validated in iOS, Android and browser.
Added new unit tests, if relevant.

Design Review

In case this PR contains changes to the UI, add some screenshots and/or videos to show the changes on relevant devices.

Screen.Recording.2026-01-30.at.14.44.10.mov

jimcase · 2026-02-04T11:02:04Z

I got an issue @Sotatek-DukeVu
In the initiator wallet when creating a group identifier 3/3:

Go the confirm screen.
Set Required signers to 3 members.
Set Recovery signers to 3 memebrs.
Edit group member by removing 1 member.
The Required signers and Recovery signer still says "3 members".
I click on Send requests.
I get the error toast "Unable to create group"

The Required signers and Recovery signers values should be reset(or signers form prompted, see figma designs) and Send requests button should be disabled.

Tested on real devices: Android 15 and iOS26

Sotatek-DukeVu · 2026-02-05T02:29:21Z

I got an issue @Sotatek-DukeVu In the initiator wallet when creating a group identifier 3/3:

Go the confirm screen.

Set Required signers to 3 members.

Set Recovery signers to 3 memebrs.

Edit group member by removing 1 member.

The Required signers and Recovery signer still says "3 members".

I click on Send requests.

I get the error toast "Unable to create group"

The Required signers and Recovery signers values should be reset(or signers form prompted, see figma designs) and Send requests button should be disabled.

Tested on real devices: Android 15 and iOS26

@jimcase It has been fixed in this PR: #1564.

jimcase · 2026-02-05T09:05:45Z

I got an issue @Sotatek-DukeVu In the initiator wallet when creating a group identifier 3/3:

Go the confirm screen.

Set Required signers to 3 members.

Set Recovery signers to 3 memebrs.

Edit group member by removing 1 member.

The Required signers and Recovery signer still says "3 members".

I click on Send requests.

I get the error toast "Unable to create group"

The Required signers and Recovery signers values should be reset(or signers form prompted, see figma designs) and Send requests button should be disabled.
Tested on real devices: Android 15 and iOS26

@jimcase It has been fixed in this PR: #1564.

Okey, so please, merge develop branch to this PR so we can test it properly.

iFergal · 2026-02-05T11:13:14Z

@jimcase Duke has force pushed, so I think the changes are there. I tested and it works.

However, after step 4, what are we doing - pressing back? The changes seem to take affect so I think there's something wrong with the other PR. I will check over there in that ticket.

From my POV, this PR resolves the related bug.

iFergal · 2026-02-05T11:20:58Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

+
+      if (groupDetails) {
+        memberData = memberData.filter((connection) => {
+          return groupDetails?.members.some(


iFergal · 2026-02-05T11:21:38Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

    identity?.id,
  ]);

+  const getMemberConnections = useCallback(


I think it would be cleaner to have 2 functions - one that accepts GroupInformation and one that accepts MultiSigIcpRequestDetails

iFergal · 2026-02-05T11:23:05Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

+      let memberData = [...connections];
+
+      if (groupDetails) {
+        memberData = memberData.filter((connection) => {


groupDetails has the aid and name of each member in the group. Why do we need to filter connections - are the extra fields of ConnectionShortDetails actually used?

The reason I filter connections here is because this data will be set back into the initialState.selectedConnections state in SetupGroupProfile. This state is then passed down to PendingGroup.

Basically, this state is where we store the connections that were scanned and selected during the setup screen. At this point, we only need a single function to display the member list.

iFergal · 2026-02-05T11:24:57Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

+        });
+      }
+
+      if (multisigIcpDetails && isPendingMember) {


Why can't we also just use multisigIcpDetails.otherConnections and multisigIcpDetails.sender directly? These are already in the right format of MultisigConnectionDetails which extends ConnectionShortDetails

iFergal · 2026-02-05T13:48:30Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

+        if (
+          memberConnections.length == state.selectedConnections.length &&
+          state.selectedConnections.every((item) =>
+            memberConnections.some((m) => m.contactId == item.contactId)


also don't see the need for this extra if statement to do a diff. Faster and easier to just remove this (and on line 340)

iFergal · 2026-02-05T13:49:26Z

src/ui/pages/SetupGroupProfile/SetupGroupProfile.tsx

-      selectedConnections: currentProfile.multisigConnections,
+      selectedConnections: isPendingState
+        ? []
+        : currentProfile.multisigConnections,


Why is this change needed?

currentProfile.multisigConnections currently contains members who were not selected. Because of that, it would be confusing if the screen first displayed the full list of users in the group and then removed the users who are not participating. Therefore, I will set this prop to empty and populate it again after the core function returns the correct data.
On the UI, it will initially display an empty state, and after loading finishes, it will show the member list.

iFergal · 2026-02-05T14:01:14Z

src/ui/pages/SetupGroupProfile/components/PendingGroup/PendingGroup.tsx

            mainContent={`${i18n.t(
-              `setupgroupprofile.initgroup.setsigner.members`,
+              `setupgroupprofile.initgroup.setsigner.${
+                (signingThreshold || 0) > 1 ? "members" : "member"


These don't exist...

Also, before I initiate, I still see "1 members" - not sure if another PR fixes that

Sotatek-DukeVu requested review from iFergal and jimcase January 30, 2026 08:42

Sotatek-DukeVu self-assigned this Jan 30, 2026

fix(ui): fix display group members

de7d46a

Sotatek-DukeVu force-pushed the VT20-2574-omitted-profiles-shown-in-group-list-while-setting-group-up branch from ae82485 to de7d46a Compare February 5, 2026 02:29

iFergal reviewed Feb 5, 2026

View reviewed changes

Conversation

Sotatek-DukeVu commented Jan 30, 2026 • edited by iFergal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist before requesting a review

Issue ticket number and link

Testing & Validation

Design Review

Uh oh!

jimcase commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sotatek-DukeVu commented Feb 5, 2026

Uh oh!

jimcase commented Feb 5, 2026

Uh oh!

iFergal commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sotatek-DukeVu commented Jan 30, 2026 •

edited by iFergal

Loading

jimcase commented Feb 4, 2026 •

edited

Loading