fix(ui): Group IPEX refresh notifications are duplicated in Redux if we are in another profile#1574
Conversation
…tification's wallet
|
Tested on real devices: Android15 and iOS26 |
| ).toEqual(undefined); | ||
| }); | ||
|
|
||
| it("should delete notification when it's not current profile's notification", () => { |
There was a problem hiding this comment.
"should delete notification, despite being on a different profile at the time"
| Object.values(state.profiles).forEach((profile) => { | ||
| profile.notifications = profile.notifications.filter( | ||
| (n) => n.id !== action.payload | ||
| ); |
There was a problem hiding this comment.
While this works, it seems a bit wasteful because:
a) it keeps filtering other profiles even after the notification is filtered out.
b) it's still way more likely that the default profile will contain it, given natural user flows.
I propose this:
const defaultProfile = state.profiles[state.defaultProfile];
if (defaultProfile) {
const idx = defaultProfile.notifications.findIndex(
(notification) => notification.id !== action.payload
);
if (idx !== -1) {
defaultProfile.notifications.splice(idx, 1);
return;
}
}
for (const profile of Object.values(state.profiles)) {
if (profile === defaultProfile) continue;
const idx = profile.notifications.findIndex(
(notification) => notification.id !== action.payload
);
if (idx !== -1) {
profile.notifications.splice(idx, 1);
break;
}
}
On dev, I'm seeing these scroll bars when I scroll but not sure why. Not on a real iOS device. Any ideas?
|
Because the scroll element now has 100% height after Jaime added it, we can no longer rely on ion-content for scrolling and hiding the scrollbar using &::-webkit-scrollbar. I’ve fixed this issue and the fix has been merged into develop. You can rebase this PR onto develop to verify it. |
3 participants
…tification's wallet
Description
Fix group IPEX refresh notifications are duplicated in Redux if we are in another profile
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
Screen.Recording.2026-02-04.at.15.05.28.mov