Open
Conversation
v0d1ch
reviewed
Feb 19, 2026
Contributor
v0d1ch
left a comment
v0d1ch
left a comment
There was a problem hiding this comment.
I am not sure how much this improves the current situation. Perhaps we should also do another experiment where we just use a handle with needed functions instead of type class approach?
| ChainBackend backend => | ||
| backend -> | ||
| ChainBackend m => | ||
| MonadIO m => |
Contributor
There was a problem hiding this comment.
Why do we still need MonadIO m here? Looks like it should work out without this constraint?
| ChainBackend backend => | ||
| backend -> | ||
| ChainBackend m => | ||
| MonadIO m => |
| forall backend. | ||
| ChainBackend backend => | ||
| backend -> | ||
| forall backend r. |
| backend -> | ||
| forall m. | ||
| ChainBackend m => | ||
| MonadIO m => |
Contributor
There was a problem hiding this comment.
Are these extra constraints needed?
| -- starting another BF related test. | ||
| delayBF backend | ||
| action (getShelleyGenesisBlockTime shelleyGenesis) backend | ||
| -- TODO: Implement delay using the backend |
Contributor
There was a problem hiding this comment.
Is this a leftover or we actually need to implement it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.