Use UUIDs for document IDs in insert_documents method#18
Merged
juntao merged 2 commits intocardea-mcp:mainfrom May 31, 2025
Merged
Use UUIDs for document IDs in insert_documents method#18juntao merged 2 commits intocardea-mcp:mainfrom
juntao merged 2 commits intocardea-mcp:mainfrom
Conversation
Signed-off-by: Acuspeedster <arnavrajsingh@gmail.com>
Contributor
|
What about the point_id in load_data.py? Which point ID is it using when I run the load data script. |
Collaborator
Author
|
@juntao Looking at the |
Contributor
|
I know this. I am just pointing to a code quality problem. We should not have the same code segments littered in different files. It is a maintenance issue. Shouldn't load_data just call the insert_document instead of upsert in this case? |
…n; enhance error handling and logging Signed-off-by: Acuspeedster <arnavrajsingh@gmail.com>
Collaborator
Author
|
@juntao I have improved the codes' maintainability as much as I could have potentially seen. |
juntao
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing to be aware of: this change will affect any existing data in your Qdrant store. If we already have vectors in your collections that were inserted with sequential IDs, and we now start inserting with UUIDs, we'll have a mix of ID formats. This won't cause errors but might be confusing when examining the data directly. If we need to work with existing data and maintain consistency, we might want to:
Create new collections Re-index all your data with UUIDs Switch to the new collections when complete.